Skip to content

Support latest opentelemetry version for tracing sdk#18534

Merged
samvaity merged 6 commits intoAzure:masterfrom
samvaity:opentelemetry-update
Jan 26, 2021
Merged

Support latest opentelemetry version for tracing sdk#18534
samvaity merged 6 commits intoAzure:masterfrom
samvaity:opentelemetry-update

Conversation

@samvaity
Copy link
Member

@samvaity samvaity commented Jan 11, 2021 •
edited
Loading

This PR adds support to the latest opentelemetry-api , 0.14.1 for tracing sdk azure-core-tracing-opentelemetry and Azure Monitor OpenTelemetry Exporter client library for Java.

Closes : #18512

@samvaity samvaity requested review from srnagar and trask January 11, 2021 07:42
@ghost ghost added the Azure.Core azure-core label Jan 11, 2021
@samvaity samvaity self-assigned this Jan 11, 2021
@samvaity samvaity force-pushed the opentelemetry-update branch from 444aa90 to 5e19756 Compare January 11, 2021 07:45
@samvaity samvaity mentioned this pull request Jan 12, 2021
Closed
@samvaity samvaity force-pushed the opentelemetry-update branch from 2abe73f to 4c9bec2 Compare January 13, 2021 00:56
@samvaity samvaity force-pushed the opentelemetry-update branch from 4c9bec2 to 29ec743 Compare January 13, 2021 01:27
@check-enforcer
Copy link

check-enforcer bot commented Jan 19, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

@samvaity samvaity force-pushed the opentelemetry-update branch 4 times, most recently from 3779c63 to 517c8e0 Compare January 20, 2021 02:55
@samvaity samvaity marked this pull request as ready for review January 20, 2021 22:19
@samvaity samvaity force-pushed the opentelemetry-update branch from 444abd3 to 01b6712 Compare January 20, 2021 22:24
alzimmermsft
alzimmermsft reviewed Jan 21, 2021
View reviewed changes
srnagar
srnagar reviewed Jan 21, 2021
View reviewed changes
pom.xml
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>3.1.0</version> <!-- {x-version-update;org.apache.maven.plugins:maven-checkstyle-plugin;external_dependency} -->
<version>3.1.1</version> <!-- {x-version-update;org.apache.maven.plugins:maven-checkstyle-plugin;external_dependency} -->
Copy link
Member

@srnagar srnagar Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be updated in external_dependencies.txt

Copy link
Member Author

@samvaity samvaity Jan 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be correct in the dependency file - https://github.com/Azure/azure-sdk-for-java/blob/master/eng/versioning/external_dependencies.txt#L232 ?

@samvaity samvaity force-pushed the opentelemetry-update branch from f1a7450 to 90655a5 Compare January 22, 2021 22:12
@samvaity samvaity requested a review from srnagar January 25, 2021 21:03
srnagar
srnagar approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samvaity samvaity merged commit 5884ffc into Azure:master Jan 26, 2021
@samvaity samvaity deleted the opentelemetry-update branch June 22, 2021 20:41
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this pull request Apr 11, 2022
CodeGen from PR 18534 in Azure/azure-rest-api-specs
3f8e00d 
[Hub Generated] Review request for Microsoft.LoadTestService to add version preview/2022-04-15-preview (Azure#18534)

* Adds base for updating Microsoft.LoadTestService from version preview/2021-12-01-preview to version 2022-04-15-preview

* Updates readme

* Updates API version in new specs and examples

* v2022-04-01-prev, commiting with existing version

* update 2022-04-01-preview spec

* update examples in 2022-04-01-preview

* updated 2022-04-15-preview spec

* updated examples for 2022-04-15-preview

* updated markdown files

* Deleted 2022-04-01-preview from the public spec

* prettify json

* updated examples to contain encryption properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alzimmermsft alzimmermsft alzimmermsft approved these changes

@srnagar srnagar srnagar approved these changes

@trask trask Awaiting requested review from trask

@danieljurek danieljurek Awaiting requested review from danieljurek

@JimSuplizio JimSuplizio Awaiting requested review from JimSuplizio

@JonathanGiles JonathanGiles Awaiting requested review from JonathanGiles

@joshfree joshfree Awaiting requested review from joshfree

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

@mssfang mssfang Awaiting requested review from mssfang

Assignees

@samvaity samvaity

Labels

Azure.Core azure-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Add support for latest OpenTelemetry versions to Azure Monitor OpenTelemetry Exporter client library for Java

3 participants

@samvaity @alzimmermsft @srnagar